#21 refactor mbs.get_modules
Closed 4 years ago by qwan. Opened 4 years ago by qwan.

Currently we have a param named auto_next_page in mbs.get_modules to get items from all pages, it has shortcomings:
1. not consistent with the supported query params in MBS, so it's easy to make mistake or not aware of its existence.
2. when there are many items in total (e.g. hundreds of items), get all modules will result in multiple calls to MBS with default per_page=10, this is unnecessary, we can reduce it to up to 2 calls, the first one is getting the first page by default, and then if pages > 1, we issue another call with per_page=total.


Metadata Update from @qwan:
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata