#57 Python3 Support
Merged 5 years ago by frantisekz. Opened 5 years ago by frantisekz.

file modified
+10 -5
@@ -10,14 +10,18 @@ 

  

  Packages:

   - libvirt

-  - libvirt-python

+  - python2-libvirt

+  - python3-libvirt

   - libguestfs

   - libguestfs-tools

-  - python-requests (for whatever python version you're running)

+  - python2-requests

+  - python3-requests

  

  Optional (if you plan on running or working on the tests):

   - python2-pytest

-  - python-pytest-cov

+  - python3-pytest

+  - python2-pytest-cov

+  - python3-pytest-cov

  

  All of these packages are in the Fedora repos (and likely other distros as

  well).
@@ -113,7 +117,8 @@ 

  

  .. code:: bash

  

-     py.test

+     python2 -m pytest

+     python3 -m pytest

  

  This is a good place to contribute if you're looking to help out.

  
@@ -121,7 +126,7 @@ 

  --------------------------

  

  Our project tracker is on the Fedora QA-devel

- `Phabricator <https://phab.qa.fedoraproject.org/tag/testcloud/>`_

+ `Pagure <https://pagure.io/testcloud//>`_

  instance.

  

  Credit

file modified
+8 -1
@@ -11,6 +11,7 @@ 

  import argparse

  import logging

  import os

+ import sys

  import libvirt

  from . import config

  from . import image
@@ -353,7 +354,13 @@ 

  

      _configure_logging()

  

-     args.func(args)

+     try:

+         args.func(args)

+     except AttributeError:

+         # If no cmdline args were provided, func is missing

+         # https://bugs.python.org/issue16308

+         parser.print_help()

+         sys.exit(1)

  

  

  def find_vm_ip(name, connection='qemu:///system'):

Testcloud itself looks pretty happy under Python 3, (proper) packaging remains to be dealt with before merging.

rebased onto 76ec69c0c2d8e08526b513b8b591d363e2c8ea8d

5 years ago

1 new commit added

  • Update Readme
5 years ago

Looks good! Please squash and merge, then close this PR. Thanks.

rebased onto 6a6f856

5 years ago

Pull-Request has been merged by frantisekz

5 years ago
Metadata