#42 Added consumer for Github's Pull Requests
Merged by tflink. Opened by jskladan.
feature/github  into  develop

Download 42.patch

Pull-Request has been merged by tflink

But... I don't get it. This will run task-mtf on all github PRs that fedmsg watches! Or am I mistaken?

We want to run mtf just for specific repositories. According to his comments, it should be projects under https://github.com/container-images/*. Shouldn't we add a regex line to match those?

This should be task-mtf-containers (https://pagure.io/task-mtf-containers) according to the ticket.

@kparal this will, in fact, run nothing, on its own. This is Trigger's code, not deployment.

Bare in mind, that there is a difference between the trigger code, tests and examples, and the way trigger is actually configured in ansible and deployed.

The "enable this on our servers" is unrelated to the trigger_rules.yml.example file. If for nothing else, then for the fact we don't have either task-mtf-containers nor task-mtf among the mirrored tasks on the buildmasters...

I understand where you are coming from, but the comments are not really related to this particular PR.

Right, I got confused. Thanks.

Metadata