Issue #57: makefile fails if there's something after %{dist} in spec - taskotron-trigger

taskotron / taskotron-trigger

#57 makefile fails if there's something after %{dist} in spec

Closed: Fixed 6 years ago Opened 6 years ago by kparal.

If you set something like this in taskotron-trigger.spec:

Release:        2%{?dist}.copr01

and then run make mocksrpm, the last command (cp) fails:

Zapsáno: /builddir/build/SRPMS/taskotron-trigger-0.6.0-2.fc28.copr01.src.rpm
Finish: rpmbuild -bs
Finish: buildsrpm
INFO: Done(taskotron-trigger.spec) Config(fedora-28-x86_64) 1 minutes 41 seconds
INFO: Results and/or logs in: /var/lib/mock/fedora-28-x86_64/result
Finish: run
cp /var/lib/mock/fedora-28-x86_64/result/taskotron-trigger-0.6.0-2.copr01.fc28.src.rpm .
cp: cannot stat '/var/lib/mock/fedora-28-x86_64/result/taskotron-trigger-0.6.0-2.copr01.fc28.src.rpm': No such file or directory
make: *** [Makefile:80: mocksrpm] Error 1

It tried to copy the wrong file:

taskotron-trigger-0.6.0-2.copr01.fc28.src.rpm

instead of

taskotron-trigger-0.6.0-2.fc28.copr01.src.rpm

Of course this is @frantisekz's fault, because he's been messing up with the makefiles :-) Frantisek, please fix this in all make targets and in all our makefiles in all our projects. Thanks!