Issue #43: please ignore fNN-modular-updates-testing tag events - taskotron-trigger

taskotron / taskotron-trigger

#43 please ignore fNN-modular-updates-testing tag events

Closed: Fixed 6 years ago Opened 6 years ago by kparal.

Some of our tasks (I've seen rpmdeplint, but I assume upgradepath should as well) are executed on fNN-modular-updates-testing koji tag events. That seems to be a new tag related to the modular server release. Our tasks crash on it:

[libtaskotron:logger.py:88] 2017-10-31 13:02:27 CRITICAL Traceback (most recent call last):
  File "/usr/bin/runtask", line 11, in <module>
    load_entry_point('libtaskotron==0.4.24', 'console_scripts', 'runtask')()
  File "/usr/lib/python2.7/site-packages/libtaskotron/main.py", line 196, in main
    overlord.start()
  File "/usr/lib/python2.7/site-packages/libtaskotron/overlord.py", line 96, in start
    runner.execute()
  File "/usr/lib/python2.7/site-packages/libtaskotron/executor.py", line 62, in execute
    self._run()
  File "/usr/lib/python2.7/site-packages/libtaskotron/executor.py", line 98, in _run
    self._do_actions()
  File "/usr/lib/python2.7/site-packages/libtaskotron/executor.py", line 136, in _do_actions
    self._do_single_action(action)
  File "/usr/lib/python2.7/site-packages/libtaskotron/executor.py", line 157, in _do_single_action
    self.arg_data)
  File "/usr/lib/python2.7/site-packages/libtaskotron/directives/yumrepoinfo_directive.py", line 143, in process
    arch_output = self.run_yumrepoinfo(arch, params["koji_tag"])
  File "/usr/lib/python2.7/site-packages/libtaskotron/directives/yumrepoinfo_directive.py", line 112, in run_yumrepoinfo
    '%r not found.' % koji_tag)
TaskotronDirectiveError: Repo with tag'f27-modular-updates-testing' not found.

http://taskotron-dev.fedoraproject.org/taskmaster/builders/x86_64/builds/725617/steps/runtask/logs/stdio

We don't really have any tasks to do any meaningful job with this. So I believe we should ignore these tags as we ignore all the others. This problem occurred because we only check for -updates-testing suffix in the trigger rules, I believe. We'll need to be smarter about it.

Metadata Update from @jskladan:
- Issue assigned to jskladan

6 years ago

jskladan commented 6 years ago

@kparal and I decided to solve this by changing the trigger rules for rpmdeplint/upgradepath (the only tasks running on KojiTagChanged now) by properly defining what tags we care about in the trigger configuration, changing the config like this:

diff --git a/roles/taskotron/taskotron-trigger/templates/trigger_rules.yml.j2 b/roles/taskotron/taskotron-trigger/templates/trigger_rules.yml.j2
index 0e5b5d34c..cd8a4bd26 100644
--- a/roles/taskotron/taskotron-trigger/templates/trigger_rules.yml.j2
+++ b/roles/taskotron/taskotron-trigger/templates/trigger_rules.yml.j2
@@ -18,7 +18,11 @@
   do:
     - {tasks: [abicheck]}

-- when: {message_type: KojiTagChanged}
+- when:
+    message_type: KojiTagChanged
+{% if deployment_type in ['dev'] %}
+    tag: {$regex: '/^f[0-9]{2}-updates(-testing)?-pending$$/'}
+{% endif %}
   do:
     - {tasks: [rpmdeplint]}

@@ -26,7 +30,11 @@
 {# stg bodhi doesn't have the info we need, stg koji doesn't have the builds from prod bodhi #}
 - when:
     message_type: KojiTagChanged
+{% if deployment_type in ['dev'] %}
+    tag: {$regex: '/^f[0-9]{2}-updates-pending$$/'}
+{% else %}
     tag: {$regex: '/.*(?<!testing-pending)$$/'}
+{% endif %}
   do:
     - {tasks: [upgradepath]}
 {% endif %}