Chalk this one up to something that we all missed :)
There was a recent change to #taskotron-trigger which added daemon == 1.1 to requirements.txt. Unfortunately, the only version of python-daemon available on f23 is 1.6 and when you install trigger from RPM, there is a traceback in taskotron-trigger.log on startup:
daemon == 1.1
python-daemon
1.6
[2016-04-13 15:48:35][moksha.hub ERROR] Failed to load 'kojibuildcompletedjobtrigger' consumer. Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/moksha/hub/hub.py", line 353, in __init_consumers c = consumer.load() File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2354, in load self.require(*args, **kwargs) File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2371, in require items = working_set.resolve(reqs, env, installer) File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 839, in resolve raise DistributionNotFound(req, requirers) DistributionNotFound: The 'daemon' distribution was not found and is required by the application [2016-04-13 15:48:35][moksha.hub ERROR] Failed to load 'composecompletedjobtrigger' consumer. Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/moksha/hub/hub.py", line 353, in __init_consumers c = consumer.load() File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2354, in load self.require(*args, **kwargs) File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2371, in require items = working_set.resolve(reqs, env, installer) File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 839, in resolve raise DistributionNotFound(req, requirers) DistributionNotFound: The 'daemon' distribution was not found and is required by the application [2016-04-13 15:48:35][moksha.hub ERROR] Failed to load 'kojitagchangedjobtrigger' consumer. Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/moksha/hub/hub.py", line 353, in __init_consumers c = consumer.load() File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2354, in load self.require(*args, **kwargs) File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2371, in require items = working_set.resolve(reqs, env, installer) File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 839, in resolve raise DistributionNotFound(req, requirers) DistributionNotFound: The 'daemon' distribution was not found and is required by the application
The question I'm running into is: do we really need python-daemon? I can't see anywhere that it's used and when I build a local RPM with the daemon == 1.1 line removed from requirements.txt, everything things to work fine for trigger.
requirements.txt
Does anyone remember why the daemon dep was added and why it wasn't added to the specfile? Are there any objections to dropping the dep from requirements.txt?
daemon
This ticket had assigned some Differential requests: D814 D804
I think @jsedlak couldn't make taskotron-trigger work in virtualenv without daemon. I install the trigger to system-wide location on my laptop when testing so it's similar to the production env and so I haven't tested in virtualenv. I removed it from setup.py in D804 because it was failing on dev machine (installed from rpm). It's odd that it needs to be removed from requirements.txt too. Anyway, no objections to removing it.
taskotron-trigger
Login to comment on this ticket.