#2 Add 'priority.fedora.compose' FedoraComposeResult item
Closed 7 years ago by adamwill. Opened 7 years ago by adamwill.

@@ -47,6 +47,30 @@ 

          super(FedoraComposeResult, self).__init__(composeinfo, *args, **kwargs)

          self.conventions.append('fedora.compose')

  

+     def default_extradata(self):

+         """Include a test 'priority'. Note, this is a short term hack

+         until a better system for tracking this is in place. Testing

+         systems are expected to provide this value somehow. This value

+         indicates the importance of the test in the context of a

+         Fedora distribution compose. The value should be a string

+         integer. Value meanings:

+             1 - critical smoke test, if this fails, compose is busted

+             2 - test must pass for compose to be of Alpha quality

+             3 - test must pass for compose to be of Beta quality

+             4 - test must pass for compose to be of Final quality

+             5+ - test is 'optional', no gating significance

+         Default value is 10, so all tests are considered 'optional'

+         (won't be taken into account for gating) unless this value is

+         changed in a subclass or directly on the instance by the

+         reporting code.

+         """

+         super(FedoraComposeResult, self).default_extradata()

+         extradata = {

+             'priority.fedora.compose': '10',

+         }

+         extradata.update(self.extradata)

+         self.extradata = extradata

+ 

      def default_groups(self):

          super(FedoraComposeResult, self).default_groups()

          # update the existing compose group with a URL

file modified
+1
@@ -116,6 +116,7 @@ 

          assert res.extradata == {

              'item': 'Fedora-Server-dvd-x86_64-Rawhide-20170131.n.1.iso',

              'meta.conventions': 'result productmd.compose fedora.compose productmd.image fedora.image',

+             'priority.fedora.compose': '10',

              'productmd.compose.date': '20170131',

              'productmd.compose.id': 'Fedora-Rawhide-20170131.n.1',

              'productmd.compose.name': 'Fedora',

This extradata item is intended to convey the 'priority' of
the test in the context of a Fedora distribution compose. This
is a short-term hack to allow releng to make useful decisions
about compose quality until we have a more appropriate system
for tracking this kind of information. The system that sends
results to ResultsDB for each test system is expected to set
this value appropriately (e.g. fedora_openqa for openQA results,
autocloudreporter for Autocloud results).

@jskladan @jsedlak @ralph @ausil thoughts? Note, I've already added this feature to autocloudreporter (can easily back it out again if necessary) and there is a diff for fedora_openqa to do the same.

Once this is done I intend to write a PoC which will simply mail Dennis after every Rawhide compose and tell him whether it's releasable or not. :P

rebased

7 years ago

I'm abandoning this, as @jskladan doesn't like it. We'll take a different tack.

Pull-Request has been closed by adamwill

7 years ago