#422 Provide both python2 and python3 libs
Merged by frantisekz. Opened by frantisekz.
packaging_rework  into  develop

Download 422.patch

Taskotron now consists of three packages:
* taskotron-runner (runtask + disposable client deps)
* python2-libtaskotron
* python3-libtaskotron

Upgrade Path should work just fine, testing builds are available here: https://copr.fedorainfracloud.org/coprs/frantisekz/taskotron-stack-python3/

Me no understand :D I guess this will be up for @kparal to tackle...

Metadata Update from @kparal:
- Request assigned

rebased onto 8f03305e3ddb2d402e815f5c90e8f60c4e3e4899

rebased onto 64076dc61e2a4e775d92d53c375a9ca6db990c6b

Please update description and summary for all packages to reflect the new state.

The Requires and BuildRequires lines used to be sorted by alphabet (except for if-else-endif blocks where it made sense to group some of those together) for easier searching. Please make them sorted again.

Let's say "runtask and taskotron_result" here to make it clearer that the intention is to keep both, thanks.

Edit: Thinking more about this, why is it even needed? All old libtaskotron packages are obsoleted by taskotron_runner. So people will end up with taskotron_runner anyway, which already requires python2-libtaskotron. Why do we need this reverse dependency?

That doesn't seem right. The package has been replaced. Was something else supposed to be here?

I guess readme and license should be part of all subpackages. Previously it was just in libtaskotron-core, but that was a basic requirement of everything else, so it was also always installed. You can check some guidelines for this, I'd simply include it everywhere.

Could you make the directories and files definitions less scattered around? Some of them are at the top, some of them are down here. Put them into one place and make them sorted, please.

You can be more specific, like "Build the library for both python2 and python3, rename the subpackages. Put runtask into taskotron-runner and succeed libtaskotron-disposable with it. ..." or something like that.

rebased onto f6bf3cd0aef57c7c9c719e189c6415fad38cdcdf

Okay, I've force pushed the update.

All your feedback should be addressed, thanks!
I've left some Requires/BuildRequires unsorted - the ones that are inside if fedora > xy .

Also, I've found out and fixed an issue with Python 3 tests - running just:

%{__python3} setup.py test

is not enough to actually run it with Python 3 (it runs with Python 2). I've made changes to setup.py, let me know if you like the way I've worked around the issue.

If it's okay, I'll apply the same fix to all our Py2/3 projects (I've looked into testcloud and it's affected the same way).

rebased onto b6c55cd536ef34b3f11211ccb659a4749c7e5177

1 new commit added

  • Little bit of cleaning here and there

rebased onto a3793067dedb16c27fa354f451651fea2bf7a5c9

1 new commit added

  • fix indentation

ACK. Let's hope for the best.

4 new commits added

  • Bump to 0.9.2 Because of setup.py changes
  • Finish rebasing on top of latest develop
  • Little bit of cleaning here and there
  • Provide both python2 and python3 libs

rebased onto 4a4de681e3ac005f05d1a5763e4006967cc10b61

rebased onto d48d9ef9975e28326ea24f8b7bfc598d11575dbd

Commit 3db27547 fixes this pull-request

Pull-Request has been merged by frantisekz

Metadata