#416 doit: update dodo.py to work with Python 3
Merged by kparal. Opened by kparal.
feature/doit3  into  develop

Download 416.patch

This allows the doit commands to be executed with system doit using
python3 (or from venv if you prefer, but doit with py2 support is
available only in an old version). All commands should work without
venv active, simplifying build process, except builddocs - that requires
venv active. It is be possible to automatically create venv for
builddocs and use it, but it would require more extensive patches.

1 new commit added

  • devguide: install python3-progressbar from RPM

BTW, why exactly are we usig doit instead of Makefile in libtaskotron (all our other projects use Makefile IMO)?
Looking at the code it seems to be just a more complicated version of Makefile, with the added general akwardness of running shell-scripts from Python.

Not that I care at all what we use (Makefile vs doit), just curious to what the actual benefits over Makefile (de-factor standard) are.

Python 3 support looks/works just fine.

Removing the Makefile... seems bit unrelated.

BTW, why exactly are we usig doit instead of Makefile in libtaskotron (all our other projects use Makefile IMO)?
Looking at the code it seems to be just a more complicated version of Makefile, with the added general akwardness of running shell-scripts from Python.

That question would be best directed at @tflink. I personally don't care, doit is easier to maintain (it's python and I never remember makefile syntax), Makefile is more common.

Not that I care at all what we use (Makefile vs doit), just curious to what the actual benefits over Makefile (de-factor standard) are.

Me neither. I only strongly object to having 2 build scripts simultaneously, that's why I revert the recent undiscussed addition of Makefile. If anyone wants to replace doit with Makefile, feel free to submit PR, but please replace it, do not just add it. That means the new Makefile should retain the existing doit functionality (all build targets), unless some of them are not needed anymore (perhaps some of the CI stuff? please ask @tflink).

I assume everything's been cleared up, merging.

Commit 79f6168c fixes this pull-request

Pull-Request has been merged by kparal

Metadata