taskotron / libtaskotron

#414 Python 3 support for tests
Merged by kparal. Opened by churchyard.
taskotron/ churchyard/libtaskotron py3tox  into  develop

Download 414.patch

I am able to run the tests with:

  • tox -v -e py36 -- -v

There is one test that fail on me:

  • test_run_playbook_simple fails on Python 2 and Python 3 consistently, I don't know what's wrong

https://github.com/laurentb/xunitparser/issues/10

Added a workaround for the xunitparser bug. Changed the PR description.

1 new commit added

  • Python 3: Workaround a bug in xunitparser

1 new commit added

  • Python 3: Add py36 tox testenv to tox.ini

Thanks!

I don't seem to be able to install progressbar for python3 virtualenv or tox. Does that work for you?

Collecting progressbar>=2.3 (from -r requirements.txt (line 14))
  Using cached https://files.pythonhosted.org/packages/0f/e1/f30b72ecabba259c7c38dd0eb944a173effced3fd7de2c9c2902bd6f649a/progressbar-2.3.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-kmxyd6o8/progressbar/setup.py", line 5, in <module>
        import progressbar
      File "/tmp/pip-install-kmxyd6o8/progressbar/progressbar/__init__.py", line 59, in <module>
        from progressbar.widgets import *
      File "/tmp/pip-install-kmxyd6o8/progressbar/progressbar/widgets.py", line 121, in <module>
        class FileTransferSpeed(Widget):
      File "/home/kparal/devel/taskotron/libtaskotron/env3/lib64/python3.6/abc.py", line 133, in __new__
        cls = super().__new__(mcls, name, bases, namespace, **kwargs)
    ValueError: 'format' in __slots__ conflicts with class variable
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-kmxyd6o8/progressbar/

If I install the package as a Fedora RPM, it works.

test_run_playbook_simple fails on Python 2 and Python 3 consistently, I don't know what's wrong

It works for me, so it's not a regression. We can look into it, but it's not essential for this PR.

Don't know why, but that happened to me as well. i suppose it's a bug in progressbar. RPM version is what I've used.
Edited by churchyard

https://stackoverflow.com/a/33063959/1839451

I made a few changes. Once copr works, this will get deployed to taskotron-dev and we'll see how it works.

Commit 9685f7e7 fixes this pull-request

Pull-Request has been merged by kparal

Thanks a lot, Miro. Merged.

np :) thanks for quick merging.
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.