This ticket also depends on https://pagure.io/taskotron/task-upgradepath/issue/12

This ticket had assigned some Differential requests:
D523
D511
D514
D506
D505
D509

The testing Bodhi 2 instance is here:
https://bodhi.stg.fedoraproject.org/

There's a patch for libtaskotron from Luke:
https://bitbucket.org/fedoraqa/libtaskotron/pull-requests/2/bodhi_utils-changes-for-bodhi2/diff

I'm going to have a look at it.

So far I've filed the following python-fedora issues:
https://github.com/fedora-infra/bodhi/issues/161
https://github.com/fedora-infra/bodhi/issues/162
https://github.com/fedora-infra/bodhi/issues/163
https://github.com/fedora-infra/bodhi/issues/164 (this one is problematic for us)

It's likely I'll file some more, will link them here.

Filed bug against bodhi2 to not show results with state 'ABORTED': https://github.com/fedora-infra/bodhi/issues/167

Please note that D506 is a patch against current develop, but it contains many other changes that we haven't deployed yet (some of them not even to dev) and I'm not sure we want to do deploy it all together. I'll prepare another patch against current master.

It turns out that the difference between master and develop is quite small and mostly differs in Bodhi code, which is going to change anyway. So the easiest approach here is to merge develop into master. Hotpatching master would include much more work.

NOTE: query_update() is now broken, and referenced by bodhi and bodhi comments directives. bodhi is not used anywhere, but bodhi comments is. We will need to disable bodhi commenting in the server config file, if we want to deploy it as it is.

Bodhi comments will need further changes:
1) We will need to change all Bodhi update handling to use alias (updateid) instead of mix of alias/title/builds. The new API no longer allows that.
2) We will need to wait until https://github.com/fedora-infra/bodhi/issues/164 is released in a python-fedora update.
3) Possibly more changes, I haven't gotten any further because of getting stuck on 2).

Querying by update alias was added in python-fedora 0.5.4, even though it does not show up in the docstring (https://github.com/fedora-infra/bodhi/issues/181). I'll work now on using it to reenable bodhi comments directive.

Posting Bodhi comments is currently stuck on https://github.com/fedora-infra/bodhi/issues/185

pushed upgradepath fix to dev, stg and prod

Bodhi emails are working. Let's close this.

This issue depended on a ticket not moved from Phabricator.
T580: Figure out why depcheck isn't finding updates for most of the builds

In depcheck runs that I've done post bodhi 2.0 upgrade, the code is only finding 3 updates for 75 builds which seems ... wrong to me.

T578 is masking most of the rest of depcheck, so this will need to happen after that's fixed.

This issue depended on a ticket not moved from Phabricator.
T578: don't assume that update['alias'] exists in updates

The changes for bodhi2 were done under the assumption that an alias would be guaranteed to exist going forward.

It turns out that this is not quite the case - alias is only guaranteed to exist on updates created with bodhi2 or pushed to testing before the upgrade. Any updates pending push at the time of the bodhi2 upgrade don't have an alias and depcheck is crashing when the default None from those updates which are missing an alias.

Rework the squash_results code such that it isn't expecting to always find an alias