#234 Adding package ownership of /var/tmp/taskotron prevents buildbot from executing task
Closed: Fixed None Opened 8 years ago by tflink.

rLTRNcb237606de4c added /var/tmp/taskotron as a directory created and owned by the libtaskotron package. It references D266 but I'm not able to find the directory change in that revision - not sure what happened there.

When executing tasks in dev/stg/prod, buildbot removes this directory to get rid of any tmpfiles created during earlier task executions. This directory is now owned by root, causing the buildbot job to fail before it does anything.

As a short-term fix, I've manually removed /var/tmp/taskotron from the dev and stg clients so that everything isn't failing. Prod isn't an issue because 0.3.13 was never deployed there.

We need to have a longer-term solution to this - either revert the /var/tmp/taskotron creation/ownership in the specfile or change the builmaster config so that it isn't trying to delete the directory.


It references D266 but I'm not able to find the directory change in that revision - not sure what happened there.
Phab doesn't work correctly with multi-commit diffs. You can see it if you diff Base to Diff 5 in D266:
https://phab.qadevel.cloud.fedoraproject.org/D266?vs=on&id=849&whitespace=ignore-most#toc
Diff 6 is automatically added and it just contains the first commit that referenced D266, not all of them.

In D266, I assumed that missing /var/tmp/taskotron/ from the spec file was a simple omission, so I added it. I got inspired by ABRT:

$ rpm -qf /var/tmp/abrt
abrt-2.3.0-4.fc21.x86_64

I haven't found anything in the packaging guidelines that would say this is a bad idea (or a good idea:)). Advice from packaging guru is welcome.

The correct approach seems to be to just erase the contents of the the directory, not the whole directory, in the buildbot cleanup phase?

Login to comment on this ticket.

Metadata