#213 bodhi comments can be submitted multiple times
Closed: Fixed None Opened 9 years ago by tflink.

I noticed that there were duplicate bodhi comments on a f20 update:
https://admin.fedoraproject.org/updates/livecd-tools-20.6-1.fc20

When I looked at the [[https://taskotron.fedoraproject.org/taskmaster//builders/x86_64/builds/6116/steps/runtask/logs/stdio| logs from the later of the comments]], I see:

[libtaskotron:bodhi_comment_directive.py:451] 2014-10-27 20:39:42 INFO    Current test result is already present in bodhi.
[libtaskotron:bodhi_comment_directive.py:271] 2014-10-27 20:39:44 INFO    checking email needed for livecd-tools-20.6-1.fc20 (updates-testing)
[libtaskotron:bodhi_comment_directive.py:238] 2014-10-27 20:39:44 INFO    Current State of update livecd-tools-20.6-1.fc20 :
  {'depcheck_64': u'PASSED', 'upgradepath': 'PASSED', 'depcheck_32': u'PASSED'}
  {'result': u'PASSED', 'arch': u'i386', 'testname': u'depcheck', 'time': datetime.datetime(2014, 10, 27, 20, 9, 52)}
  {'result': u'PASSED', 'arch': u'x86_64', 'testname': u'depcheck', 'time': datetime.datetime(2014, 10, 27, 20, 9, 58)}
[libtaskotron:bodhi_comment_directive.py:238] 2014-10-27 20:39:44 INFO    Current State of update livecd-tools-20.6-1.fc20 :
  {'depcheck_64': u'PASSED', 'upgradepath': 'PASSED', 'depcheck_32': 'PASSED'}
  {'result': u'PASSED', 'arch': u'i386', 'testname': u'depcheck', 'time': datetime.datetime(2014, 10, 27, 20, 9, 52)}
  {'result': u'PASSED', 'arch': u'x86_64', 'testname': u'depcheck', 'time': datetime.datetime(2014, 10, 27, 20, 9, 58)}
  {'result': 'PASSED', 'arch': 'i386', 'testname': 'depcheck', 'time': datetime.datetime(2014, 10, 27, 20, 39, 44, 626426)}
[libtaskotron:bodhi_comment_directive.py:281] 2014-10-27 20:39:44 INFO    update state : state_PASS to state_PASS
[libtaskotron:bodhi_comment_directive.py:476] 2014-10-27 20:39:46 INFO    The test result was sent to bodhi successfully.
[libtaskotron:bodhi_comment_directive.py:451] 2014-10-27 20:39:47 INFO    Current test result is already present in bodhi.

Something is not right here - additional bodhi comments should have been prevented. Investigate the cause and propose a reasonable fix, if there is one.


This ticket had assigned some Differential requests:
D691

Bodhi2 seems imminent, so we probably don't need to deal with this anymore. Until then, leaving here with low priority.

Hasn't this been fixed (or not happening with bodhi2)?

Hard to say. Let's wait a while until #556 is resolved and then we can close this :)

Login to comment on this ticket.

Metadata