#148 clean up the 'arch' mess
Closed: Fixed None Opened 9 years ago by kparal.

When it comes to architecture handling, we're in a mess. Originally, it was a single architecture, and the variable was called ${arch}. Then it got expanded to a list of architectures, but the variable is still called ${arch} (which is confusing). Some code and some directives handle it as a list, some assume it's a single-item list or simply a string (maybe fixed now). Some directives add automatically something to it, some directives strip something from it, some directives hardcode things like this:

            if 'all' in input_data['arch']:
                arches = ['i386', 'x86_64', 'noarch', 'armhfp']

Go through all code and all tasks. Find all use cases for arch. Then propose the solution - it can be having two different variables (${arch} for main arch, ${arches} for all arches to work with, like noarch, srpm etc), or maybe getting rid of the option to specify multiple arch on the command line, or something else.


As a short-term measure, it has been collectively agreed that we should fix those tasks that I added as dependencies. Some other fixes will probably be needed in the future, but let's cover that when at that point of time with a new ticket.

All blocking tasks have been fixed, closing. Thanks, @lbrabec!

Metadata Update from @kparal:
- Issue marked as depending on: #189
- Issue marked as depending on: #190
- Issue marked as depending on: #191
- Issue marked as depending on: #192
- Issue marked as depending on: #193

6 years ago

Login to comment on this ticket.

Metadata