#4 write pylint engines for arcanist
Closed: Fixed None Opened 10 years ago by tflink.

When doing code reviews with arcanist/phabricator, it is possible to submit lint and unit test results with that code review. In order to do this, there needs to be interface code for the unit test runner and linter that we're interested in (py.test and pylint, respectively).

[[http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide_Customizing_Lint,_Unit_Tests_and_Workflows.html|The phabricator docs for customizing workflows]] cover some of this but the existing code is limited
* [[https://github.com/facebook/arcanist/tree/master/src/unit/engine|unit test engine interfaces]]
* [[https://github.com/facebook/arcanist/tree/master/src/lint/engine|lint engine interfaces]]

For now, develop the engines as a separate library - either stored as a php library (which we can package) or in one of the projects here. Eventually, we'll want to look into contributing the results upstream but let's get it working first :)

Since phabricator doesn't really have a concept of versions, use the packages for arcanist, phabricator and libphutil that we're already using.


This ticket had assigned some Differential requests:
D257

I believe Lukas has given up this task.

Just FYI - arcanist seems to have the PEP8 linter already implemented: https://github.com/phacility/arcanist/blob/master/src/lint/linter/ArcanistPEP8Linter.php and they even provide quite a few examples using the PEP8 linter here https://secure.phabricator.com/book/phabricator/article/arcanist_lint/

I'll write a simple .arclint file to try out pep8/pylint/whatever

Metadata Update from @tflink:
- Issue tagged with: easyfix, infrastructure

6 years ago

Login to comment on this ticket.

Metadata