#90 Add a bit more information to the duplicate email template
Merged 4 years ago by sidpremkumar. Opened 4 years ago by sidpremkumar.
sidpremkumar/sync-to-jira email-template-changes  into  develop

file modified
+3 -2
@@ -130,8 +130,9 @@ 

          final_results = []

  

          for result in results_of_query:

-             # If the queried JIRA issue has the id of the upstream issue or the same title

-             if issue.id in result.fields.description or issue.title == result.fields.summary:

+             description = result.fields.description or ""

+             summary = result.fields.summary or ""

+             if issue.id in description or issue.title == summary:

                  search = check_comments_for_duplicate(client, result,

                                                        find_username(issue, config))

                  if search is True:

@@ -2,6 +2,12 @@ 

    <body style="font-family: Arial; font-size: 14px;">

      <p> Hello {{ user['name'] }}, <br>It looks like you have some duplicate issues for

          upstream issue <a href="{{ issue.url }}">{{ issue._title }}</a></p>

+     <p>This issue was selected:</p>

+      <ul>

+          <li>

+              <a href="{{ selected_issue['url'] }}">{{ selected_issue['title'] }}</a>

+          </li>

+      </ul>

    <p>But these issues were also found:</p>

      <ul>

        {% for duplicate in duplicate_issues %}

no initial comment

:+1: to the template change, but this PR seems to also accidentally include that commit from #88 (and that one has some feedback on it).

👍 to the template change, but this PR seems to also accidentally include that commit from #88 (and that one has some feedback on it).

I'll make sure that it's the same as what we agreed on from #88 before merge.

2 new commits added

  • Adding more information to duplciate-emails sent out
  • Adding check for JIRA issue fields before checking
4 years ago

rebased onto e0cea40

4 years ago

Pull-Request has been merged by sidpremkumar

4 years ago