If you use --with-systemd on a non-systemd system, it should detect the lack of header files and set result no, instead of continuing and failing to build.
<img alt="0001-Ticket-16-with-systemd-should-unset-have-systemd-if-.patch" src="/svrcore/issue/raw/files/e9cb0f3278319a614b95a125f45e4ee91138979fe0cc517de96a9e96f3f03645-0001-Ticket-16-with-systemd-should-unset-have-systemd-if-.patch" />
I would need to check Fedora packaging guidelines[1] Because I am not sure whether you can rely on fact that systemd is part of build-root. It might be better to use BuidRequires: pkgconfig(systemd)
sh$ rpm -q --provides systemd | grep pkgconfig pkgconfig(systemd) = 231 pkgconfig(udev) = 231
BTW what is a purpose of following ifdef: +#ifdef HAVE_SYSTEMD +#ifndef _WIN32
If I read condition right then it will be true for systems which has systemd and are not windows. Systemd is linux only so the 2nd ifdef is redundant.
[1] http://fedoraproject.org/wiki/Packaging:Guidelines
<img alt="0001-Ticket-16-with-systemd-should-unset-have-systemd-if-.patch" src="/svrcore/issue/raw/files/6c046d5109251e5538636530fffba9c2e099e1a102dd59509ed9d55e2f56ab25-0001-Ticket-16-with-systemd-should-unset-have-systemd-if-.patch" />
Remove win32 define, and update buildrequires.
ACK, works fine with fedora and freebsd
I almost every time forget that 389-team is used to keep autoconf generated files in git. So please do not forget regenerate them. It is required due to changes in m4/systemd.m4
I'm trying to get rid of them. See http://www.port389.org/docs/389ds/design/configure-artifacts.html
commit 2e8ffb5 Compressing objects: 100% (8/8), done. Writing objects: 100% (8/8), 1.17 KiB | 0 bytes/s, done. Total 8 (delta 7), reused 0 (delta 0) To ssh://git@pagure.io/svrcore.git ed490d1..2e8ffb5 master -> master
@firstyear changed the status to Closed
Closed
Login to comment on this ticket.