standard-test-roles

#75 Stick to PEP8. Fix exceptions flow
Closed by sturivny. Opened by sturivny.
Unknown source master

Download 75.patch

Cleanup code and test it

Catching object of base class Exception is a bad style. This a cause of many hidden nasty bugs.

Let's write universal function. -> Define a default return value. At least describe what will be if working_host != "local" ?

I cannot get idea behind "sys.exit(1)" ....
In case of exception python will do exactly the same: print info about exception + return with value != 0.

Pull-Request has been closed by sturivny
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.