#73 Location for restraint repo file for Fedora Rawhide
Merged 6 years ago by astepano. Opened 6 years ago by astepano.
astepano/standard-test-roles rawhide_copr  into  master

@@ -12,16 +12,14 @@ 

      delegate_facts: True

  

    - name: Add restraint repo for restraint-rhts on Fedora hosts

-     get_url:

-       url: https://copr.fedorainfracloud.org/coprs/bpeck/restraint/repo/fedora-{{ansible_distribution_major_version}}/bpeck-restraint-fedora-{{ansible_distribution_major_version}}.repo

-       dest: /etc/yum.repos.d/restraint.repo

+     shell: dnf copr enable -y bpeck/restraint

      when: ansible_distribution == 'Fedora'

  

    - name: Add restraint repo for restraint-rhts on RHEL/CentOS hosts

-     get_url:

-       url: https://copr.fedorainfracloud.org/coprs/bpeck/restraint/repo/epel-7/bpeck-restraint-epel-7.repo

-       dest: /etc/yum.repos.d/restraint.repo

-     when: ansible_distribution == 'RedHat' or ansible_distribution == 'CentOS'

+     block:

+       - package: name=yum-plugin-copr

+       - shell: yum copr -y enable bpeck/restraint

+     when: "[ansible_distribution] | intersect(['RedHat', 'CentOS'])"

  

    - name: Install the beakerlib requirements

      package: name={{item}} state=latest

This PR fixes: https://pagure.io/standard-test-roles/issue/68
provides correct URL to repo file for Fedora Rawhide.

Signed-off-by: Andrei Stepanov astepano@redhat.com

It did work for me using Fedora Rawhide.

TASK [standard-test-beakerlib : Add restraint repo for restraint-rhts on Fedora hosts] ****************************************************************************************************************************
changed: [localhost -> None]

TASK [standard-test-beakerlib : Add restraint repo for restraint-rhts on RHEL/CentOS hosts] ***********************************************************************************************************************
skipping: [localhost]

TASK [standard-test-beakerlib : Install the beakerlib requirements] ***********************************************************************************************************************************************
ok: [localhost -> None] => (item=beakerlib)
changed: [localhost -> None] => (item=restraint-rhts)
ok: [localhost -> None] => (item=rsync)

Cool, LGTM! I will also incorporate this in PR#51

Cool, LGTM! I will also incorporate this in PR#51

Ah not needed actually :) standard-test-rhts users "dnf copr enable" which works nicely on rawhide (thanks @bgoncalv for confirmation)

So could standard-test-beakerlib use dnf copr enable as well?

You mean instead of using url to download the repo, run dnf copr enable bpeck/restraint ?
I don't see a problem, if we do this only for Fedora. The code for RHEL/CentOS should not change as there is not dnf on RHEL-7.

You mean instead of using url to download the repo, run dnf copr enable bpeck/restraint ?

yes

I don't see a problem, if we do this only for Fedora. The code for RHEL/CentOS should not change as there is not dnf on RHEL-7.

sure

@bgoncalv I thought standard-test-beakerlib does not use dnf because of Atomic compatibility. Correct me if I am wrong, AFAIK there is no dnf package manager on Atomic.

@bgoncalv I thought standard-test-beakerlib does not use dnf because of Atomic compatibility. Correct me if I am wrong, AFAIK there is no dnf package manager on Atomic.

This part of code runs only for classic / container tags.

@astepano I understand, but if we use dnf here, standard-test-beakerlib will stop working on atomic, we do not want to do that :) Am I missing something?

@mvadkert

This part of code (in this PullReq) never run on Atomic host.
This code (this PullReq) runs only for classic/container.

This code is not supposed to run on Atomic Host.

If you concern about Atomic Host: please open a new bug.

@astepano acknowledged, I get it now :) no more concerns for mee. feel free to use dnf when not on atomic.

rebased onto 030328ce001310d3c95891440efeaa191d06c403

6 years ago

@bgoncalv: could I ask you to test updated PR?

Updated PR uses copr enable user/project for RHEL/CentOS/Fedora.

Thank you!

I got the following error:

==> default: fatal: [localhost]: FAILED! => {"failed": true, "msg": "The conditional check '[ansible_distribution] | intersect('RedHat', 'CentOS')' failed. The error was: Unexpected templating type error occurred on ({% if [ansible_distribution] | intersect('RedHat', 'CentOS') %} True {% else %} False {% endif %}): intersect() takes exactly 2 arguments (3 given)\n\nThe error appears to have been in '/etc/ansible/roles/standard-test-beakerlib/tasks/main.yml': line 20, column 9, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n    block:\n      - package: name=yum-plugin-copr\n        ^ here\n"}

rebased onto d246412

6 years ago

I updated PR. @bgoncalv please check again. Thanks!

It passed. Test only on Fedora Rawhide.

@bgoncalv (or anyone else), Have this been tested to confirm it doesn't break compatibility for Fedora releases other than Rawhide?

@merlinm I tested it on Fedora26. I works well on F26

Pull-Request has been merged by astepano

6 years ago
Metadata