standard-test-roles

#55 [WIP] Add bits needed to support own spec.
Closed by cevich. Opened by cevich.
cevich/standard-test-roles eat_dogfood  into  master

Download 55.patch

N/B: Cross-dependencies with https://pagure.io/standard-test-roles/pull-request/39

Signed-off-by: Chris Evich cevich@redhat.com

N/B: Cross-dependencies with https://pagure.io/standard-test-roles/pull-request/39

I'm not 100% sure how this is supposed to be used, but I ran into a couple things during my first attempt to see if I could run it. See the code review comments that follow.

Ansible complains that Name isn't a valid attribute for a task. Surely you meant name in lower casel.

The dnf after $(...) and before install shouldn't be there, otherwise it's trying to execute something like dnf dnf install ...
Edited by merlinm

It's not safe to have the same variable name on both sides. If you don't explicitly define artifacts before running this playbook, ansible explodes with something like:

TASK [Make artifacts directory] ***************************************************************************************************************************************fatal: [localhost]: FAILED! => {"failed": true, "msg": "{{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", True)) }}: {{ artifacts | default(lookup(\"env\", \"TEST_ARTIFACTS\") | default(\"./artifacts\", Tru
e)) }}: {{ artifacts...

I'm considering dropping this PR, all that and leaving it for someone else. I'm not sure this is even the right place for it, or if in dist-git is better. Lastly, time...uggg...time. Probably better focus on finishing #39 for now.
Edited by cevich

Pull-Request has been closed by cevich
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.