standard-test-roles

Clone
Source Code
GIT

#42 roles: Correct restraint task fetch URL to include test subdirectory name
Merged 6 years ago by merlinm. Opened 6 years ago by merlinm.
Unknown source restraint-0.1.31-fix  into  master

file modified
+1 -1 
@@ -3,7 +3,7 @@
 

    <recipe>
 

  {% for item in tests %}
 

      <task name='{{ item | basename }}'>
 

-      <fetch url='http://localhost:{{ local_www_port }}/{{ item | basename }}.tgz' />
 

+      <fetch url='http://localhost:{{ local_www_port }}/{{ item | basename }}.tgz#{{ item | basename }}' />
 

      </task>
 

  {% endfor %}
 

    </recipe>

restraint-0.1.31 was just released which corrects a bug that was resulting in the flattening of the directory structure within task tarballs fetched via http. Unfortunately, the standard-test-rhts role had a bug that was masked by the bug in previous versions of restraint. As a result, all tests run using the standard-test-rhts role now fail to start due to restraint attempting to run them from the incorrect directory.

Symptoms of the problem were indicated by the following messages in each test's restraint harness.log:

** Preparing metadata
use_pty:FALSE make testinfo.desc
make: *** No rule to make target 'testinfo.desc'.  Stop.

This PR corrects the issue by appending the test subdirectory name to the task fetch URL in restraint's job.xml file as described in the restraint documentation.

Pull-Request has been merged by merlinm
6 years ago
Metadata
None
No Tags
Changes Summary 1
+1 -1
file changed
roles/standard-test-rhts/templates/job.xml.j2
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.