PR#387: make sure qcow2 inventory removes termporary files -

standard-test-roles

#387 make sure qcow2 inventory removes termporary files

Merged Jul 9, 2020 by astepano. Opened Jul 9, 2020 by bgoncalv.

bgoncalv/standard-test-roles fix-standard-inventory-qcow2 into master

Download 387.patch

no initial comment

astepano commented Jul 9, 2020

Thank you for the fix

astepano commented Jul 9, 2020

Commit 966c65d1 fixes this pull-request

Pull-Request has been merged by astepano

Jul 9, 2020

Pull-Request has been merged by astepano

Jul 9, 2020

bgoncalv commented Jul 9, 2020

tested using build from https://download.copr.fedorainfracloud.org/results/@osci/standard-test-roles/fedora-31-x86_64/01540353-standard-test-roles/

The provision.fmf is:

standard-inventory-qcow2:
qemu:
    drive:
    - size: 10737418240
    - size: 10737418240
    - size: 10737418240

No temporary file existed after playbook finished.

Running with TEST_DEBUG=1 files got removed after killing the process as informed by the role:

[INFO ] standard-inventory-qcow2: kill 14163 # when finished to debug VM
# kill 14163 
[INFO ] standard-inventory-qcow2: Diagnose ending.
[INFO ] standard-inventory-qcow2: Closing and removing temporary sparse file '/tmp/tmpmmv2hd7y'
[INFO ] standard-inventory-qcow2: Closing and removing temporary sparse file '/tmp/tmpfx52rjz0'
[INFO ] standard-inventory-qcow2: Closing and removing temporary sparse file '/tmp/tmp9ux31jyb'

Metadata

Assignee

None

Tags

No Tags

standard-test-roles

#387 make sure qcow2 inventory removes termporary files Merged Jul 9, 2020 by astepano. Opened Jul 9, 2020 by bgoncalv. bgoncalv/standard-test-roles fix-standard-inventory-qcow2 into master

Metadata

#387 make sure qcow2 inventory removes termporary files

Merged Jul 9, 2020 by astepano. Opened Jul 9, 2020 by bgoncalv.

bgoncalv/standard-test-roles fix-standard-inventory-qcow2 into master