Signed-off-by: Andrei Stepanov astepano@redhat.com
@bgoncalv could you please copy the file to some environment and test how it works? I tested it in my environment - it works for me.
@astepano I didn't test it, but the fix should be for the basic role, not beakerlib
rebased onto 45995c82673081fefd6b7224ff1c1f1a8fbd8a71
@bgoncalv updated also basic-role. If you want to keep current behaviour for beakerlib-role let me know, I will remove modifications for it.
thanks, I'll try the fix for basic role. I think beakerlib doesn't need this fix, I'd prefer if you can drop it.
it didn't work, as it logged all stdout entries first and then stderr.
test script:
1 2 3 4 5 6 7
#!/usr/bin/sh >&2 echo "error1" echo pass1 >&2 echo "error2" echo pass2 echo pass3 >&2 echo "error3"
result:
pass1 pass2 pass3 error1 error2 error3
expected result:
error1 pass1 error2 pass2 pass3 error3
@bgoncalv https://pagure.io/fedora-ci/general/issue/57#comment-576252
my test script has the output saved in the correct order if I run:
runtest.sh > output.log 2>&1
cat output.log error1 pass1 error2 pass2 pass3 error3
@bgoncalv please send a PR with your fix.
would you be okay with having just a single file with both stdout and stderr?
@bgoncalv I am not happy with this approach, but if majority wants this, let's do in this way.
Pull-Request has been closed by astepano
Signed-off-by: Andrei Stepanov astepano@redhat.com