PR#371: fix yamllint reported errors under tests/ -

standard-test-roles

#371 fix yamllint reported errors under tests/

Merged Sep 25, 2019 by astepano. Opened Sep 25, 2019 by bgoncalv.

bgoncalv/standard-test-roles fix-yaml-syntax into master

bgoncalv commented Sep 25, 2019

With the fix some warnings are still left...

# yamllint -d "{extends: default, rules: {line-length: {max: 120}, indentation: disable}}"  tests/
tests/prepare.yml
2:1       warning  missing document start "---"  (document-start)
tests/avocado.yml
2:1       warning  missing document start "---"  (document-start)
13:20     warning  truthy value should be one of [false, true]  (truthy)
tests/rhts.yml
1:1       warning  missing document start "---"  (document-start)
28:20     warning  truthy value should be one of [false, true]  (truthy)
tests/inventory.yml
1:1       warning  missing document start "---"  (document-start)
tests/source.yml
2:1       warning  missing document start "---"  (document-start)
tests/basic.yml
1:1       warning  missing document start "---"  (document-start)
56:20     warning  truthy value should be one of [false, true]  (truthy)
90:20     warning  truthy value should be one of [false, true]  (truthy)
tests/beakerlib.yml
1:1       warning  missing document start "---"  (document-start)
30:20     warning  truthy value should be one of [false, true]  (truthy)
63:20     warning  truthy value should be one of [false, true]  (truthy)
tests/shared-tasks/verify_failed_test.yml
2:1       warning  missing document start "---"  (document-start)
tests/shared-tasks/req-pkg.yml
1:1       warning  missing document start "---"  (document-start)
tests/shared-tasks/artifacts_test_env.yml
2:1       warning  missing document start "---"  (document-start)
tests/shared-tasks/verify_error_test.yml
2:1       warning  missing document start "---"  (document-start)
tests/shared-tasks/artifacts_test_runner.yml
2:1       warning  missing document start "---"  (document-start)
tests/shared-tasks/artifacts.yml
2:1       warning  missing document start "---"  (document-start)

bgoncalv commented Sep 25, 2019

@astepano the python syntax failed, and it seems to be a problem with astroid version 2.3.0 module. If I use downgrade it to 2.2.5 then inspekt lint --enable W0611,W0612,W0622 --disable W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611 /standard-test-roles/scripts/merge-standard-inventory works well...

astepano commented Sep 25, 2019

@bgoncalv should get "green" confirmation from Jenkins?

bgoncalv commented Sep 25, 2019

@astepano it is testing on python syntax, as on my comment above, if you want the test to be fixed now what I can do is update tests/python-syntax.sh to force astroid==2.2.5 to be installed.

astepano commented Sep 25, 2019

@bgoncalv please update, thank you!

1 new commit added

freeze python modules for python-syntax.sh

Sep 25, 2019

bgoncalv commented Sep 25, 2019

@astepano now it passed the tests, but Error: Login invalid/expired. Please visit https://copr.fedorainfracloud.org/api to get or renew your API token.

astepano commented Sep 25, 2019

ha-ha

astepano commented Sep 25, 2019

pretty please pagure-ci rebuild

bgoncalv commented Sep 25, 2019

and it is green :D

astepano commented Sep 25, 2019

@bgoncalv thank you!

astepano commented Sep 25, 2019

Commit 823e9f62 fixes this pull-request

Pull-Request has been merged by astepano

Sep 25, 2019