#369 rename parameter save-files to save_files
Merged 4 years ago by astepano. Opened 4 years ago by bgoncalv.
bgoncalv/standard-test-roles fix-role  into  master

@@ -23,7 +23,7 @@ 

   * **dir**: test directory. default: is the test name

   * **run**: command to run the test. default: ./runtest.sh

   * **timeout**: abort test case after this time. More details on [timeout][1]. default: 0

-  * **save-files**: List of extra files to save to artifacts.

+  * **save_files**: List of extra files to save to artifacts.

     Path to the file is relative to test directory. The files are saved to

     artifacts under test name directory. default: None

  
@@ -41,6 +41,8 @@ 

          - smoke27:

              dir: python/smoke

              run: VERSION=2.7 METHOD=virtualenv ./venv.sh

+             save_files:

+               - venv.sh

          - smoke37:

              dir: python/smoke

              run: VERSION=3.7 ./venv.sh

@@ -20,7 +20,7 @@ 

                  --test "{{ item if item.keys is not defined else (item.keys()|list)[0] }}" \

                  --timeout "{{ '0' if item.keys is not defined else item[(item.keys()|list)[0]]['timeout']|default('0') }}" \

                  --cmd "{{ './runtest.sh' if item.keys is not defined else item[(item.keys()|list)[0]]['run']|default('./runtest.sh') | regex_replace('\\', '\\\\') | regex_replace('\"', '\"') | regex_replace('\$', '\\$') }}" \

-                 --save-files "{{ '' if item.keys is not defined else item[(item.keys()|list)[0]]['save-files']|default('') | join(',') | regex_replace('\\', '\\\\') | regex_replace('\"', '\"') | regex_replace('\$', '\\$') }}"

+                 --save-files "{{ '' if item.keys is not defined else item[(item.keys()|list)[0]]['save_files']|default(item[(item.keys()|list)[0]]['save-files']|default('')) | join(',') | regex_replace('\\', '\\\\') | regex_replace('\"', '\"') | regex_replace('\$', '\\$') }}"

      with_items:

      - "{{ tests }}"

  

file modified
+1 -1
@@ -103,7 +103,7 @@ 

      tests:

      - test-basic-save-files:

          run: echo "file1" > file1.log; echo "file2" > file2.log

-         save-files:

+         save_files:

            - file*.log

      - basic-save-files-dir:

          dir: test-basic-save-files-dir

use save_files as other parameters also use '_' and not '-'.

Keep compatibility with save-files, this can be removed later on.

Added usage example on README.md

Commit a351b67 fixes this pull-request

Pull-Request has been merged by astepano

4 years ago

Pull-Request has been merged by astepano

4 years ago