standard-test-roles

#331 docker: Use is-active to determine docker status
Merged by astepano. Opened by till.
till/standard-test-roles use_is_active  into  master

Download 331.patch

Only run systemctl start docker when systemctl is-active docker
fails. The start command is privileged and therefore requires manual
authentication if it is run by a non-root user even if the service is
already active. The check with is-active is possible without special
privileges. This allows to use the inventory file if the current user is
in the docker group.

Jenkins seems to point to the wrong URL, it mentions a commit by Stef Walter instead of mine:
https://jenkins-fedora-atomic-process.apps.ci.centos.org/job/str_pr_test/346/changes#detail0

Btw. an alternative would be to not start the docker service at all... It seems to be a little bit intrusive IMHO.

rebased onto 5749801bd5a8ffcc175798afb7f5a118dc8301f5

Seems the jenkins log is correct but it is not very clear where to find the actual failure IMHO. Should be fixed now.

I've tested the copr build for this PR [1] and it worked well.

I think it is nice improvement not start the service if it is already started.

Just note the STI [2] says the playbook must be run as root.

[1] https://copr.fedorainfracloud.org/coprs/g/osci/standard-test-roles/build/884105/
[2] https://docs.fedoraproject.org/en-US/ci/standard-test-interface/#_invocation

@bgoncalv thank you!
Merging.

Commit bafaf13c fixes this pull-request

Pull-Request has been merged by astepano

Pull-Request has been merged by astepano
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.