#298 The pkg_mgr should be yum not yum4 for rhel8.
Closed 5 years ago by astepano. Opened 5 years ago by xiaofwan.
xiaofwan/standard-test-roles fix_pkg_mgr  into  master

@@ -27,7 +27,7 @@ 

           'rpm-ostree' if (is_atomic and

                               (ansible_pkg_mgr == 'unknown' or

                                ansible_pkg_mgr == 'atomic_container'))

-          else 'yum4' if is_rhel8_based

+          else 'yum' if is_rhel8_based

           else ansible_pkg_mgr

        }}

  

There's no pkgs-yum4.yml but pkgs-yum.yml in tasks folder.

Hi.

You sent a PR for pkg_mgr.
You want to set value for pkg_mgr to yum.

But, why do you want to do this?

pkg_mgr is used at:

./roles/str-common-pkgs/tasks/main.yml:38:- include_tasks: "pkgs-{{ pkg_mgr | trim}}.yml"

We use this to include tasks specially for RHEL8. They are internal only now. RHEL8 is not released yet.

Yum in RHEL 8 has version 4: yum-4.0.9.2-4.el8.noarch.rpm

Why do you propose this change?

Hi @astepano,
Thanks for reply.
After install standard-test-roles in my f29 machine by dnf install standard-test-roles according to https://fedoraproject.org/wiki/CI/Tests, ansible reported an error about cannot find pkgs-yum4.yml. There's no pkgs-yum4.yml but pkgs-yum.yml in tasks folder. So I sent a PR to fix it.

Pull-Request has been closed by astepano

5 years ago