standard-test-roles

Clone
Source Code
GIT

#266 Support skipping disabled tests in the fmf filter
Merged 5 years ago by astepano. Opened 5 years ago by psss.
psss/standard-test-roles disabled  into  master

file modified
+3 
@@ -37,4 +37,7 @@ 
 

              fmf.utils.info("No metadata found for '{0}'.".format(path))
 

              continue
 

          for node in tree.prune(keys=['test'], filters=[filtr]):
 

+             # Skip disabled tests
 

+             if node.data.get('disabled', False):

Seems to be wrong, maybe leftover from enabled. A test should be skipped if disabled is true

 
+                 continue
 

              print(path + (node.data.get('path') or node.name))

There is a new CI Metadata attribute proposed for temporarily
disabling broken tests. This commit adds support for this.
https://pagure.io/fedora-ci/metadata/pull-request/1

Seems to be wrong, maybe leftover from enabled. A test should be skipped if disabled is true

@psss @plautrba should we merge this?

@plautrba, why wrong? The ‘False‘ is there just to provide default if ‘disabled‘ attribute is not defined.

aha. I was interpreted the code wrong way. Please ignore my comment and feel free to merge it.

Commit 7f41fff fixes this pull-request

Pull-Request has been merged by astepano
5 years ago

Pull-Request has been merged by astepano
5 years ago
Metadata
None
No Tags
Changes Summary 1
+3 -0
file changed
scripts/str-filter-tests
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.