PR#198: Add task for enabling services - standard-test-roles

standard-test-roles

#198 Add task for enabling services

Merged 5 years ago by astepano. Opened 5 years ago by dhodovsk.

dhodovsk/standard-test-roles required-services into master

Dominika Hodovska • 5 years ago

218f3f7

file modified

		`@@ -15,5 +15,7 @@`
		using the `rpm-ostree` command which is affecting the test subject (it's
		`similar as rebuilding an rpm package to be tested) so this should be used`
		`with caution and only when necessary.`
		`+ * required_services: A list of services to be started before running tests.`
		+ Please use `required_packages` for specifying packages that provide the services.

		Check `glib2` package tests to find examples for using this role.

roles/str-common-init/tasks/main.yml

file modified

		`@@ -31,3 +31,10 @@`
		`src: "{{ playbook_dir }}/"`
		`dest: "{{ tenv_workdir }}"`
		`ssh_args: "-o UserKnownHostsFile=/dev/null"`
		`+`
		+ - name: Start services defined in `required_services`
		`+ service:`
		`+ name: "{{ item }}"`
		`+ state: started`
		`+ with_flattened:`
		`+ - "{{ required_services\|d\|list\|flatten }}"`

dhodovsk commented 5 years ago

Based on: https://pagure.io/standard-test-roles/pull-request/185#comment-53185

ttomecek commented on line 5 of roles/standard-test-basic/README.md 5 years ago

The wording is a bit cumbersome, how about: A list of services to be started before running tests.

ttomecek commented on line 6 of roles/standard-test-basic/README.md 5 years ago

I propose not to do this, since a bunch of services have different name than the package which installs them. Therefore please just advise people to use required_packages variable.

ttomecek commented on line 5 of roles/str-common-init/tasks/main.yml 5 years ago

please remove this line, as described above

ttomecek commented on line 14 of roles/str-common-init/tasks/main.yml 5 years ago

Final nit: how about just Start services defined in \required_services``

rebased onto 218f3f7

5 years ago