standard-test-roles

#160 python syntax test
Merged by astepano. Opened by bgoncalv.
bgoncalv/standard-test-roles python-syntax-test  into  master

Download 160.patch

Current results:

Running: inspekt indent /root/standard-test-roles/inventory/standard-inventory-docker
Indentation check PASS
Running: inspekt lint --enable W0611,W0612,W0622 --disable W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611 /root/standard-test-roles/inventory/standard-inventory-docker
Pylint disabled: W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611
Pylint enabled : W0611,W0612,W0622
Using config file /dev/null
Syntax check PASS
Running: pycodestyle --max-line-length=120 /root/standard-test-roles/inventory/standard-inventory-docker
Running: inspekt indent /root/standard-test-roles/inventory/standard-inventory-rpm
Indentation check PASS
Running: inspekt lint --enable W0611,W0612,W0622 --disable W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611 /root/standard-test-roles/inventory/standard-inventory-rpm
Pylint disabled: W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611
Pylint enabled : W0611,W0612,W0622
Using config file /dev/null
Syntax check PASS
Running: pycodestyle --max-line-length=120 /root/standard-test-roles/inventory/standard-inventory-rpm
Running: inspekt indent /root/standard-test-roles/inventory/standard-inventory-local
Indentation check PASS
Running: inspekt lint --enable W0611,W0612,W0622 --disable W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611 /root/standard-test-roles/inventory/standard-inventory-local
Pylint disabled: W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611
Pylint enabled : W0611,W0612,W0622
Using config file /dev/null
Syntax check PASS
Running: pycodestyle --max-line-length=120 /root/standard-test-roles/inventory/standard-inventory-local
Running: inspekt indent /root/standard-test-roles/inventory/standard-inventory-vagrant
Indentation check PASS
Running: inspekt lint --enable W0611,W0612,W0622 --disable W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611 /root/standard-test-roles/inventory/standard-inventory-vagrant
Pylint disabled: W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611
Pylint enabled : W0611,W0612,W0622
Using config file /dev/null
Syntax check PASS
Running: pycodestyle --max-line-length=120 /root/standard-test-roles/inventory/standard-inventory-vagrant
Running: inspekt indent /root/standard-test-roles/inventory/standard-inventory-qcow2
Indentation check PASS
Running: inspekt lint --enable W0611,W0612,W0622 --disable W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611 /root/standard-test-roles/inventory/standard-inventory-qcow2
Pylint disabled: W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611
Pylint enabled : W0611,W0612,W0622
Using config file /dev/null
Syntax check PASS
Running: pycodestyle --max-line-length=120 /root/standard-test-roles/inventory/standard-inventory-qcow2
Running: inspekt indent /root/standard-test-roles/roles/standard-test-beakerlib/files/rpm.py
Indentation check PASS
Running: inspekt lint --enable W0611,W0612,W0622 --disable W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611 /root/standard-test-roles/roles/standard-test-beakerlib/files/rpm.py
Pylint disabled: W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611
Pylint enabled : W0611,W0612,W0622
Using config file /dev/null
Syntax check PASS
Running: pycodestyle --max-line-length=120 /root/standard-test-roles/roles/standard-test-beakerlib/files/rpm.py
Running: inspekt indent /root/standard-test-roles/scripts/merge-standard-inventory
Indentation check PASS
Running: inspekt lint --enable W0611,W0612,W0622 --disable W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611 /root/standard-test-roles/scripts/merge-standard-inventory
Pylint disabled: W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0611
Pylint enabled : W0611,W0612,W0622
Using config file /dev/null
Syntax check PASS
Running: pycodestyle --max-line-length=120 /root/standard-test-roles/scripts/merge-standard-inventory

I'm not sure if ./tests/install_test_dependencies.sh should be called on Jenkinsfile...

rebased onto c4ca841731d20cbf8c916fcd56e708bbaf49ff8b

Hi, let's

  1. remove this file completely.
  2. change dnf to yum tester is based in Centos: https://pagure.io/standard-test-roles/blob/master/f/ci/Dockerfile#_1
  3. Add this line just above ./tests/python-syntax.sh line at ci/Jenkinsfile

  1. Why remove the file, isn't good to have a file that we can run to install all dependencies required to run the tests?

  2. Okay, I will update it.

  3. Sure, I can do it.

It would be very cool if inform user what is source_dir (simple:
echo "Proceed dir $source_dir" (something like this)

Very good, but not enough

file -i /usr/lib/python2.7/site-packages/pexpect.py
/usr/lib/python2.7/site-packages/pexpect.py: text/plain; charset=us-ascii

There are more files that ends in .py but not are 'x-python' type.

I propose add to checking list also all files that ends in .py

What is purpose run command ?
if you remove it will be the same

rebased onto 20226eca636873e1cd0418c244976d6bea11d62f

Thanks for the feedback, I've updated it with your suggestions.

pretty please pagure-ci rebuild

Commit 2b4331b4 fixes this pull-request

Pull-Request has been merged by astepano

Pull-Request has been merged by astepano
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.