PR#108: standard-tests-scripts: Implement required_packages - standard-test-roles

standard-test-roles

#108 standard-tests-scripts: Implement required_packages

Closed 5 years ago by astepano. Opened 6 years ago by martinpitt.

martinpitt/standard-test-roles standard-requirements into master

standard-tests-scripts: Implement required_packages

Martin Pitt • 6 years ago

561beca

file modified

		`@@ -14,4 +14,10 @@`

		`* tests: An array of scripts to run`
		`* files: A list of files or directories needed by the scripts`
		`+ * required_packages: A list of prerequisite packages required by`
		`+ the tests. Please note that for Atomic Host, additional`
		`+ packages will be installed using the rpm-ostree command which`
		`+ is affecting the test subject (it's similar as rebuilding an`
		`+ rpm package to be tested) so this should be used with caution`
		`+ and only when necessary.`

roles/standard-test-scripts/tasks/main.yml

file modified

+1 -1

		`@@ -2,7 +2,7 @@`
		`- name: Install testing requirements`
		`package: name={{ item }} state=present`
		`with_items:`
		`- - rsync`
		`+ - "{{ required_packages }}"`
		`when: ansible_pkg_mgr != 'unknown'`

		`- name: Copy test scripts to target`

roles/standard-test-scripts/vars/main.yml

file modified

		`@@ -1,3 +1,4 @@`
		`---`
		`tests: []`
		`files: []`
		`+ required_packages: []`

martinpitt commented 6 years ago

Replace the hardcoded rsync package with required_packages from the
test YAML.

bgoncalv commented 5 years ago

pretty please pagure-ci rebuild

astepano commented 5 years ago

I propose to stop development on this role and use standard-test-basic instead of it. Basic role should provide the same functionality.

martinpitt commented 5 years ago

Indeed, thanks for pointing out -basic. This didn't come up at the Brno hackfest (maybe -basic didn't exist yet back then?). I moved Cockpit's tests to basic, so feel free to close this one.