https://pagure.io/standard-test-roles/blob/master/f/roles/standard-test-source says:
fetch_only: If True the role will only fetch the source and will skip rpmbuild --bp part. Set to True if spec file %prep section requires packages that are not available on test runner. This defaults to False
However after debugging this based on the examples provided and after talking to @bgoncalv on IRC, it seem that there is more that this option does.
It seems that when False, the results of fedpkg prep are copied "inside", so it is possible to simply use dir: ./source to be inside the unpacked source directory. However when True, the sources are fetched "outside" and the user is left with copypasting the snippets of code below to actually be able to access the sources (and spec).
dir: ./source
This was very confusing to me, especially since I had no idea about this difference.
When fetch_only is False, the copy step is done implicitly, but when fetch_only is True the copy has to be done as part of the test, I agree the documentation lacks this explanation.
False
True
I'm not sure if we can add this copy step to be implicit with fetch_only = True that would make simpler to write the test playbooks, but if we can't do this the documentation should be improved.
@astepano what do you think?
Suggested fix: https://pagure.io/standard-test-roles/issue/384
Metadata Update from @bgoncalv: - Issue assigned to bgoncalv
Commit 63be2a4 fixes this issue
Login to comment on this ticket.