#291 if dir is not set, assume .
Opened 5 years ago by bookwar. Modified 4 years ago

The basic example from https://fedoraproject.org/wiki/CI/Standard_Test_Roles#Basic

- hosts: localhost
  roles:
  - role: standard-test-basic
    tags:
    - classic
    tests:
    - simple:
        dir: .
        run: binary --help

uses dir variable to set the work dir for a test script.
When this variable is not set, the STR fails with very confusing error message.

I think we shouldn't fail if the dir: variable is not set. Let's just use "." as default.


Hi.

It turned out that dir parameter is required for some roles.
And this is not obvious.
To make life easier for STR users we must warn them that this dir is expected for certain roles that, that relay on this parameters.

This issue has to have next steps:

  • verify if required args are specified.
  • raise "user-friendly" message if some of them are missing

https://pagure.io/standard-test-roles/blob/master/f/roles/standard-test-basic/tasks/main.yml

      cd $TEST_DIR

basic role sets dist-git/repo/tests as current directory before running test.

@bookwar can be this issue be closed?

if dir is not set, basic role will assume the test directory is the same as test case name. This is documented on role documentation [1]. Any change on default value might break some tests.

[1] https://pagure.io/standard-test-roles/blob/master/f/roles/standard-test-basic

Login to comment on this ticket.

Metadata