#5 Include username in tag name
Closed 4 years ago by lsedlar. Opened 4 years ago by lsedlar.
lsedlar/sidetag-koji-plugin user-name  into  master

file modified
+2 -1
@@ -41,6 +41,7 @@ 

      # Any logged-in user is able to request creation of side tags,

      # as long the request meets the policy.

      context.session.assertLogin()

+     username = context.session.user_data.get("name", "unknown")

  

      base_tag = get_tag(base_tag, strict=True)

  
@@ -50,7 +51,7 @@ 

  

      # event_id is just used a unique value that makes sidetags names unique

      event_id = _singleValue("SELECT get_event()")

-     sidetag_name = '{}-side-{}'.format(base_tag['name'], event_id)

+     sidetag_name = '{}-side-{}-{}'.format(base_tag['name'], username, event_id)

      sidetag_id = get_tag_id(sidetag_name, create=True)

      target_name = sidetag_name

      target_id = get_build_target_id(target_name, create=True)

This should make it easier to identify tags that were created by different users.

Please note that I have no way to test this, so careful review is needed. Particularly I'm not totally sure the user name is obtained correctly.

Not a good idea for security reasons. Closing.

Pull-Request has been closed by lsedlar

4 years ago
Metadata