#13 allow usage of security-menus outside of the spin
Merged by fab. Opened by rebus.
rebus/security-lab master  into  master

Download 13.patch

Hello,
I would like to use the security menus also outside of the security spin.

Current desktop files are quite ufriendly outside of the security spin because:
1) enforce xfce terminal (even if not installed)
Related to PR#1 5 years ago https://pagure.io/security-lab/pull-request/1
2) require root privileges for all commands (running su - for all commands)
3) enforcing usage of bash shell with not respect to individual settings

This patch should be addressing this. Plus it is adding:
- GenericName - filled with the Category - so for example typing the category name in the gnome Activities will search for the launchers from the category
- Icon of terminal
- echoes the command which is being executed
- adding possibility to have comments in the launcher, which ads possibility to search for keywords (could be possibly populated in the pkg yaml file)
- is using first command to the TryExec instead of package name to allow more than one command per package - for example dd_rescue will need dd_rhelp as well

Patch is also fixing the maintenance script in order to fail gracefully if some files cant be deleted (because they do not exist on disk or in the dellist).

And it runs desktop-file-validate after generation of the desktop files.

The .desktop files were primary created to be used with Xfce. I makes definitely sense to have security-menus present in a more generic way. There wasn't much feedback in the past about use the package with the menu. Thus, I guess that most people are fine with running the tools directly from the command-line.

Thanks for taking a look and improve the script.

Pull-Request has been merged by fab

Metadata