rpmfluff

Clone
Source Code
GIT

#4 redefine %_rpmfilename to match the default
Merged 8 years ago by jhutar. Opened 8 years ago by dcallagh.
dcallagh/rpmfluff redefine-rpmfilename  into  master

file modified
+1 
@@ -293,6 +293,7 @@ 
 

              buildArchs = (expectedArch,)
 

          for arch in buildArchs:
 

              command = ["rpmbuild", "--define", "_topdir %s" % absBaseDir,
 

+                        "--define", "_rpmfilename %%{ARCH}/%%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm",
 

                         "-ba", "--target", arch, specFileName]
 

              log = check_output(command).splitlines(True)
 

              self.__write_log(log, arch)

The %_rpmfilename macro dictates the output filename pattern for binary
packages produced by rpmbuild.

Rpmfluff is expecting to find the binary packages according to the
default pattern shipped with rpm, but something else may have redefined
this macro causing the binary packages to be written to a different
location.

For example, mock redefines %_rpmfilename to drop the arch subdirectory,
which causes rpmfluff to fail:

cp: cannot stat 'test-rpmbuild-b-0.1-1/RPMS/i386/b-0.1-1.i386.rpm': No such file or directory

because the file is actually at RPMS/b-0.1-1.i386.rpm instead.

Pull-Request has been merged by jhutar
8 years ago

Thank you!
Metadata
None
No Tags
Changes Summary 1
+1 -0
file changed
rpmfluff.py
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.