rpmdevtools

Clone
Source Code
GIT

#100 spectool: Fix functions that return True on success
Merged a year ago by ngompa. Opened a year ago by gotmax23.
gotmax23/rpmdevtools errors  into  main

file modified
+4 -4 
@@ -386,10 +386,10 @@ 
 

  

          try:
 

              self._get_file(value, directory, force, dry)
 

-             return True
 

+             return False
 

  

          except IOError:
 

-             return False
 

+             return True
 

  

      def get_patch(self, number: int, directory: str, force: bool, dry: bool, value: str = None):
 

          if not value:
 
@@ -397,10 +397,10 @@ 
 

  

          try:
 

              self._get_file(value, directory, force, dry)
 

-             return True
 

+             return False
 

  

          except IOError:
 

-             return False
 

+             return True
 

  

      def get_sources(self, directory: str, force: bool, dry: bool):
 

          failure = False

The code expects functions to return False on failures.

        for task, args in tasks:
            fail = task(*args)

            if fail:
                failure = True

Fixes: https://pagure.io/rpmdevtools/pull-request/95

Pull-Request has been merged by ngompa
a year ago

Merged, thanks!

Thanks!
Metadata
None
No Tags
Changes Summary 1
+4 -4
file changed
rpmdev-spectool
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.