CC @decathorpe who reported this in https://bodhi.fedoraproject.org/updates/FEDORA-2023-e7db0e991f

Ideally rpkg would use the same method that RPM does. I suspect rpm simply splits the string on rightmost /, but I haven't actually found it in their source code yet.

Relevant part of packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_troublesome_urls

I don't know how RPM itself handles this, but the code in spectool that handles this is here: https://pagure.io/rpmdevtools/blob/main/f/rpmdev-spectool#_348-357

needs "elif" here. We don't want both names from the URL in the list.

Thanks @lsedlar. I tested the change (with the "elif" fix) on some repos including fdupes and urlwatch which contain URLs with fragment part.

@decathorpe I can (and I will) build a new rpkg package including the patch for the fc37.

@lsedlar, @decathorpe Does it worth (just thinking, not sure) to rebuild (& reset) other updates in the Bodhi? Or would it be OK to patch it afterwards the current updates are sent to stable? There is an argument for skipping the failed check --no-verify that is suggested when the check fails.

I'm ok if you push the fix as a follow-up update.

The --no-verify CLI argument isn't really an option for me at least, because I'd need to change all my package maintenance helper scripts for this ...

The need to adjust custom scripts with --no-verify might disrupt packagers' workflow, please don't ship the broken update before shipping the fix.

Ok, I will rebuild rpkg for all updates.