#646 Disable monitoring for retiring packages
Closed by onosek. Opened by lenkaseg.
lenkaseg/rpkg 10724  into  master

Download 646.patch

Signed-off-by: Lenka Segura lsegura@redhat.com

Should be fixing this issue: https://pagure.io/releng/issue/10724

rebased onto 37d87759f45679dea3b6700f42a7af927c5ac593

This approach will need a modification in fedpkg to pass the api key to retire

rebased onto 97ab3c75034578566cee2b5738736ac854711683

rebased onto 638c4e4bc5bc0fad8f526739834bbde960169968

rebased onto 40d9331dffbe0461866d291fe1dd28ad729e1432

pretty please pagure-ci rebuild

pretty please pagure-ci rebuild

2 new commits added

  • Add tests for disable_monitoring
  • Disable monitoring for retiring packages

2 new commits added

  • Add tests for disable_monitoring
  • Disable monitoring for retiring packages

1 new commit added

  • Strip quotes from api token

3 new commits added

  • Strip quotes from api token
  • Add tests for disable_monitoring
  • Disable monitoring for retiring packages

Related pull request for fedpkg: https://pagure.io/fedpkg/pull-request/497

Thanks, @lenkaseg for implementing the feature.
rpkg is a shared library for multiple tools and you were suggested to place the functionality here. I don't see the benefit of having it in rpkg. As far as I can see, this functionality is useful only for the Fedora environment, so I would prefer having it completely in fedpkg.
I can move it there.

@onosek, that makes sense. Cool if you can move it to fedpkg then. If I can help with something, writing tests or so, please let me know.

Closed in favour of: https://pagure.io/fedpkg/pull-request/499

Pull-Request has been closed by onosek

Metadata