#620 Fix high level bandit findings
Merged by onosek. Opened by onosek.
onosek/rpkg bandit_errors  into  master

Download 620.patch

JIRA: RHELCMP-9241

These changes will probably require similar steps for dependent tools like rhpkg and fedpkg.

Signed-off-by: Ondrej Nosek onosek@redhat.com

If any xpkg tool gets here, it will be basically broken. How about just printing a deprecation warning for some time and removing the argument after other tools have had time to adjust?

debug_cmd is used only for error reporting to the user, right? It may contain improperly quoted arguments, but that may not be a big deal.

If any xpkg tool gets here, it will be basically broken. How about just printing a deprecation warning for some time and removing the argument after other tools have had time to adjust?

I think it is similar to self._rpmdefines. It also has the potential to destroy the workflow of dependent tools. I counted on that there will be changes needed on other sites needed before releasing this code.

But yes, this (change in _run_commmand) is not necessary to proceed and adds risk.

Right, rpmdefines has a different format. Yeah, I don't think that can be backwards compatible.

rebased onto a2c5cbea1a80d66485732797b72bb0b0b7543b3a

620

@christoc90

rebased onto b8d3c2850852930a5da7dd5b4e8f8b9a35acdeb2

rebased onto 88c2dd8a3ff3d4c153ed13dc46ba71546caf8cd2

Pull-Request has been merged by onosek

Metadata