PR#62: Fix push called without argument -

rpkg

#62 Fix push called without argument

Merged Jun 8, 2016 by cqi. Opened Jun 8, 2016 by lsedlar.

lsedlar/rpkg push-without-force-arg into master

lsedlar commented Jun 8, 2016

This patch fixes fedpkg retire, which calls push as a part of the
process. Since there is no --force argument on retire command, this
caused it to fail with AttributeError.

cqi commented Jun 8, 2016

Why not self.cmd.push(False) directly?

lsedlar commented Jun 8, 2016

If the attribute is present, we need to use it's value. This is supposed to handle the case when this method is called but self.args does not have force attribute.

Pull-Request has been merged by cqi

Jun 8, 2016

Metadata

Assignee

None

Tags

No Tags

rpkg

#62 Fix push called without argument Merged Jun 8, 2016 by cqi. Opened Jun 8, 2016 by lsedlar. lsedlar/rpkg push-without-force-arg into master

Metadata

#62 Fix push called without argument

Merged Jun 8, 2016 by cqi. Opened Jun 8, 2016 by lsedlar.

lsedlar/rpkg push-without-force-arg into master