#609 Add option to mockbuild use default resultdir of mock (v3)
Closed by sergiomb. Opened by sergiomb.
sergiomb/rpkg master  into  master

Download 609.patch

with this option we can avoid on every build of a different package or
version etc, create a new directory with builds results, the goal is save
disk space

Signed-off-by: Sérgio M. Basto sergio@serjux.com

Hi.
I haven't tested it yet, but when I am looking at the code, I am afraid that the use of --no-local-resultsdir would possibly disrupt --srpm-mock functionality:
https://docs.pagure.org/rpkg/releases/1.64.html#support-building-srpms-in-target-mock
It requires results in the self.cmd.mock_results_dir.

rfpkg mockbuild -N --srpm-mock

rfpkg mockbuild -N --srpm-mock --no-local-resultsdir

both worked

rebased onto ab7d9057b6cdbdedd7e1d8dd8a06a734848545d1

rebased onto 79fb1055d7e30f86674b4bcaa3c7e485e40ffae0

pretty please pagure-ci rebuild

rebased onto c622ef754b58469f39c39817cbf83ebb2f4c35aa

fedpkg mockbuild -N --srpm-mock --no-local-resultsdir works in my F35 box

rebased onto 9f64f2d8b69753818db03b2652ab25b4b06cb44f

rebased onto 55cdb19e2e1aad9e9dc2b67874f95e737623a48d

rebased onto ae3fcd6c2b3dae30fb4c2ee9c361a08d38360ea5

rebased onto d64cb85ed9b5c838077e306f7583f38b1771d491

@onosek , ok I just did a very simplified thing , if we have --srpm-mock option, --default-mock-resultdir won't be applied because only on self.cmd.mockbuild we add this opinion .

he have only 4 cmd.mockbuild, 3 got srpm_mock=True the other one have default_mock_resultdir=self.args.default_mock_resultdir

command example :

fedpkg mockbuild -N  --root epel-9-x86_64 --default-mock-resultdir

rebased onto cd6ffe47033da0bbab1e61c4586cba3eea934804

rebased onto 35ec8c4a2d75cbc49214ab97adc4f5a4f8edbbd3

Pull-Request has been closed by sergiomb

Metadata