PR#522: Fix #521 Lookaside API method doesn't return in URL - rpkg

rpkg

#522 Fix #521 Lookaside API method doesn't return in URL

Merged 4 years ago by onosek. Opened 4 years ago by sturivny.

sturivny/rpkg fix_hashtype_get_download_url into master

Fix #521 Lookaside API method doesn't return in URL

sergturi • 4 years ago

98b5495

pyrpkg/lookaside.py

file modified

+1 -1

		`@@ -54,7 +54,7 @@`

		`self.log = logging.getLogger(__name__)`

		`- self.download_path = '%(name)s/%(filename)s/%(hash)s/%(filename)s'`
		`+ self.download_path = '%(name)s/%(filename)s/%(hashtype)s/%(hash)s/%(filename)s'`

		`def print_progress(self, to_download, downloaded, to_upload, uploaded):`
		`if not sys.stdout.isatty():`

no initial comment

sturivny commented 4 years ago

Fix for the https://pagure.io/rpkg/issue/521

sturivny commented 4 years ago

@onosek, @psabata, please, take a look.

psabata commented 4 years ago

+1, LGTM.

dcantrell commented 4 years ago

+1, looks good

msrb commented 4 years ago

:thumbsup:

onosek commented 4 years ago

For which tool it has to be fixed?
In fedpkg, download_path from rpkg object is overridden (and it should work there): https://pagure.io/fedpkg/blob/master/f/fedpkg/lookaside.py
Same for rhpkg.

sturivny commented 4 years ago

Fixed for the: https://github.com/fedora-eln/distrobaker
Thank you for the update, I'll take a look.

onosek commented 4 years ago

I was discussing the change. Probably, it is safe to merge it. But I am not 100% sure whether all dependent tools use overridding or the default path.
It won't harm rhpkg, fedpkg, rfpkg. We don't know about centpkg or others (if there are any).