PR#490: Lookaside cache upload is not based on an extension -

rpkg

#490 Lookaside cache upload is not based on an extension

Merged Mar 17, 2020 by onosek. Opened Mar 12, 2020 by onosek.

onosek/rpkg detect_binaries into master

onosek commented Mar 12, 2020

Files recognized as binaries are uploaded to the lookaside cache. Its
size or file extension doesn't matter. This functionality involves
"import" command. "new-sources" command still allows any file to be
uploaded manually.

COMPOSE-4155

Signed-off-by: Ondrej Nosek onosek@redhat.com

onosek commented Mar 12, 2020

This PR goes against https://pagure.io/rpkg/pull-request/13 and it would be closed.

rebased onto cf6ca74bc56abbe189b2a85228fa9fbe022a08a3

Mar 12, 2020

lsedlar commented Mar 12, 2020

Shouldn't this exception be propagated? What is expected if unpacking fails?

lsedlar commented Mar 12, 2020

This might be better handled by some argument to Popen. universal_newlines should be available in both Python 2 and 3.

onosek commented Mar 12, 2020

Oh, raise will be added. I think threre are two similar places that have to be threated in the PR.

rebased onto 2707465f59206e65773c3ff7b412d09f217e80a9

Mar 13, 2020

lsedlar commented Mar 17, 2020

Looks good to me.

Pull-Request has been merged by onosek

Mar 17, 2020

Metadata

Assignee

None

Tags

No Tags

rpkg

#490 Lookaside cache upload is not based on an extension Merged Mar 17, 2020 by onosek. Opened Mar 12, 2020 by onosek. onosek/rpkg detect_binaries into master

Metadata

#490 Lookaside cache upload is not based on an extension

Merged Mar 17, 2020 by onosek. Opened Mar 12, 2020 by onosek.

onosek/rpkg detect_binaries into master