rpkg

#489 allow compose-id with repo-url for container_build
Merged by onosek. Opened by rcerven.
rcerven/rpkg compose_id_and_yum_repo  into  master

Download 489.patch
  • OSBS-8750

Signed-off-by: Robert Cerven rcerven@redhat.com

I am not against this change, just want to notice, that this restriction was added quite recently (half of the year) as a COMPOSE-3622. Is it OK?

Additionally, there is a help string at argument parsing, that needs to be modified in this case: 

self.container_build_parser.add_argument
    '--compose-id',
    ...
    help='ODCS composes used. Cannot be used with --signing-intent or --repo-url'
    ...

rebased onto c344a47463100395d1b0078f9c71ec14f93d546d

I am not against this change, just want to notice, that this restriction was added quite recently (half of the year) as a COMPOSE-3622. Is it OK?
Additionally, there is a help string at argument parsing, that needs to be modified in this case:
self.container_build_parser.add_argument
'--compose-id',
...
help='ODCS composes used. Cannot be used with --signing-intent or --repo-url'
...

updated help string

COMPOSE-3622 was about allowing signing-intent together with repo-url, and that restriction was byproduct, also we are allowing in underlying tools already for some time compose_ids together with repo_urls, so this is unification

OK, merging.

Pull-Request has been merged by onosek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.