PR#473: Also capture stderr in logfile -

rpkg

#473 Also capture stderr in logfile

Merged Dec 2, 2019 by onosek. Opened Dec 2, 2019 by orion.

orion/rpkg stderr into master

orion commented Dec 2, 2019

Signed-off-by: Orion Poplawski orion@nwra.com

lsedlar commented Dec 2, 2019

The command is executed with /bin/sh, and as far as I can tell |& is not supported in POSIX shells. 2>&1 | might be better.

onosek commented Dec 2, 2019

Agree, I will modify the PR that way. Thanks both.

onosek commented Dec 2, 2019

Commit 3bf32cda fixes this pull-request

Pull-Request has been merged by onosek

Dec 2, 2019

orion commented Dec 2, 2019

Are you sure that it is always executed with /bin/sh? I thought it might be executed with /bin/tcsh if that was the user's shell. But what ever works.

lsedlar commented Dec 3, 2019

Good point. The documentation only says On Unix with shell=True, the shell defaults to /bin/sh. But even if it uses user's preferred shell, it could happen that someone prefers something that does not support this operator.

Metadata

Assignee

None

Tags

No Tags

rpkg

#473 Also capture stderr in logfile Merged Dec 2, 2019 by onosek. Opened Dec 2, 2019 by orion. orion/rpkg stderr into master

Metadata

#473 Also capture stderr in logfile

Merged Dec 2, 2019 by onosek. Opened Dec 2, 2019 by orion.

orion/rpkg stderr into master