#446 Custom handler for koji watch_tasks
Merged by onosek. Opened by onosek.
onosek/rpkg custom_watch_tasks  into  master

Download 446.patch

Output text during rhpkg/fedpkg build process states that there is a 'watch_task' subcommand. When 'koji_cli' library is imported in rhpkg/fedpkg tool, it shows that command is named 'rhpkg/fedpkg watch_task' instead of 'brew/koji watch_task'. Custom handler replaces the internal one inside koji_cli library.
Additional fix in rhpkg is needed after this change is released.

Relates: rhbz#1570921
Relates: COMPOSE-2809

Signed-off-by: Ondrej Nosek onosek@redhat.com

Unline -> Unlike

I don't like hardcoding downstream name here, since it's not going to work with stage variants. How about something like:

def make_ki_handler(progname):
    def ki_handler(_, tasks, quiet):
       if not quiet:
            ...
    return ki_handler

and then use make_ki_handler(self.build_client) in individual downstreams?

rebased onto f77a568cb1dc5653262276d26b386415b5e779e9

Thanks for the suggestion.

Looks good to me.

rebased onto 910ed50456ea41995989d59a5a469799ba8d4e5b

:thumbsup:

Pull-Request has been merged by onosek

Metadata