rpkg

#419 Do not require PyGObject in setup.py
Merged by onosek. Opened by onosek.
onosek/rpkg gobject_epel7  into  master

Download 419.patch

Requiring PyGObject in setup.py causes, that on EPEL7 this component is
required although it is not listed as a specfile dependency.

Resolves: rhbz#1679365
JIRA: COMPOSE-3305

Signed-off-by: Ondrej Nosek onosek@redhat.com

It seems it is safe. I run unit-tests and it passed. I also made scratch builds for EPEL7 and tested it on a clean docker container. PyGObject is now not required for fedpkg and can be uninstalled from the system (on CentOS there is python-gobject-base in default state).

:thumbsup: from me. Having correct dependencies in setup.py is nice, but we still need system dependencies, so it does not cover everything and we can't rely on it anyway.

Pull-Request has been merged by onosek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.