PR#391: Raise an error if the module build command receives optional arguments that conflict -

rpkg

#391 Raise an error if the module build command receives optional arguments that conflict

Merged Nov 8, 2018 by lsedlar. Opened Nov 7, 2018 by mprahl.

Unknown source master

mprahl commented Nov 7, 2018

The rpkg module-build command has positional arguments with defaults. We don't want those being overwritten by --optional key=value arguments. It would just cause confusion.

lucarval commented Nov 7, 2018

:+1:

mprahl commented Nov 7, 2018

@lsedlar could you please review this as well?

cqi commented Nov 8, 2018

Looks good to me.

I would suggest to use six.assertRaisesRegex to ensure rpkgError is raised.

lsedlar commented Nov 8, 2018

:thumbsup:

rebased onto 6e68939811f4ef6967f3459f2d909bb1d234e21c

Nov 8, 2018

mprahl commented Nov 8, 2018

@cqi and @lsedlar thank you for the reviews. I made the change as suggested. Could you please merge this?

Pull-Request has been merged by lsedlar

Nov 8, 2018

Metadata

Assignee

None

Tags

No Tags

rpkg

#391 Raise an error if the module build command receives optional arguments that conflict Merged Nov 8, 2018 by lsedlar. Opened Nov 7, 2018 by mprahl. Unknown source master

Metadata

#391 Raise an error if the module build command receives optional arguments that conflict

Merged Nov 8, 2018 by lsedlar. Opened Nov 7, 2018 by mprahl.

Unknown source master