PR#384: Update description for build command - rpkg

rpkg

#384 Update description for build command

Closed 5 years ago by onosek. Opened 5 years ago by onosek.

onosek/rpkg scratch_in_private into master

No commits found

Just clarification that user should not user build command for building
from private branches. In code it was prevented earlier in past.

JIRA: COMPOSE-2110

Signed-off-by: Ondrej Nosek onosek@redhat.com

lsedlar commented on line 7 of pyrpkg/cli.py 5 years ago

The option is just --scratch.

rebased onto b3cdb35

5 years ago

onosek commented 5 years ago

Thanks, updated.

lsedlar commented 5 years ago

Looks good to me.

cqi commented on line 7 of pyrpkg/cli.py 5 years ago

AFAIK, except for rhpkg to handle private branches with prefix prefix- in internal, no other area has concept of private branch. Is it proper to mention "private branch" in rpkg? Should it be better just mention it in rhpkg?

onosek commented 5 years ago

This makes the same result and it is not part of rpkg
https://code.engineering.redhat.com/gerrit/150653

But maybe I didn't investigate COMPOSE-2110 properly and it should be resolved differently. Fernando mentioned documentation issue and command-line "documentation" is the most suitable I found.

onosek commented 5 years ago

The change in gerrit is quite ugly, so I update the JIRA to get more specific scenario or I will close this issue.

rebased onto 82f763c

5 years ago

Pull-Request has been closed by onosek

5 years ago